Skip to content

fix Reproducible Builds issue #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix Reproducible Builds issue #3416

wants to merge 1 commit into from

Conversation

hboutemy
Copy link
Contributor

@hboutemy hboutemy commented May 26, 2025 •
edited
Loading

@shroffk shroffk requested review from Copilot and removed request for Copilot May 29, 2025 13:52
Copilot

This comment was marked as duplicate.

Sign in to view

@shroffk
Copy link
Member

shroffk commented May 29, 2025

Thank you for a potential fix.

We do need to include the git properties file but I see how we might be including too much info.
If I exclude all properties except the git.commit.id and git.commit.id.abbrev I believe the checks should be fine.

+1 on removing this since I see we have the property defined twice.

<project.build.outputTimestamp>${git.commit.time}</project.build.outputTimestamp>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hboutemy @shroffk